Skip to content

Conversation

@Kriyszig
Copy link
Contributor

@Kriyszig Kriyszig commented Sep 21, 2019

  • The link to ftp.debian.org is unreliable due to a failed redirect. Instead the main URL to ftp.us.debian.org is preferred

https://bugs.python.org/issue38244

The link to ftp.debian.org is unreliable due to a failed redirect. Instead the main URL to ftp.us.debian.org is preferred

>>> from ftplib import FTP
>>> ftp = FTP('ftp.debian.org') # connect to host, default port
>>> ftp = FTP('ftp.us.debian.org') # connect to host, default port
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove 3 spaces before the comment, so that these # can be aligned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 971d84f
Sorry I didn't notice that 😅 Thanks for pointing it out

@Kriyszig Kriyszig changed the title bpo-38244: [Documentation] Fix unreliable link in to sever in ftplib.rst bpo-38244: [Documentation] Fix unreliable link to sever in ftplib.rst Sep 21, 2019
Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Kriyszig.

While I can understand the intent of this PR, I don't think we should recommend a server that's specific to a single country (if we can avoid doing so). This would not work as well for those on the opposite side of the world from the US. According to https://www.debian.org/mirror/list, it is recommended to use the following format to access their primary FTP mirrors:

 ftp.<country>.debian.org 

The only problem with using the above directly is that it wouldn't be valid in literal code, so that's up to the experts of ftplib to decide what should be used instead. But either way, we should stop recommending ftp.debian.org. From the debian-mirrors-anounce ML:

In the future, it may get services reduced, or shut down, or converted into
a globally load-balanced name, or whatever. Please don't use it.

If you're using it now, please switch to a country-based DNS name
such as ftp.us.debian.org, ftp.ca.debian.org, ftp.uk.debian.org, ...
The list of those servers is at http://www.debian.org/mirror/list

@aeros
Copy link
Contributor

aeros commented Sep 21, 2019

Expert for ftplib:
/cc @giampaolo

@matrixise matrixise requested a review from giampaolo September 26, 2019 07:08
@giampaolo
Copy link
Contributor

As long as ftp.us.debian.org is up, I'm OK with the PR as-is. If in the future we can find a better alternative we can just change it again.

@giampaolo giampaolo merged commit a741457 into python:master Sep 26, 2019
@bedevere-bot
Copy link

@giampaolo: Please replace # with GH- in the commit message next time. Thanks!

@Kriyszig Kriyszig deleted the patch-1 branch September 26, 2019 11:01
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants